netdev - Re: [PATCH net-next] ibmvnic: Add netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502119795.2219.21.camel@perches.com>
Date:   Mon, 07 Aug 2017 08:29:55 -0700
From:   Joe Perches <joe@...ches.com>
To:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>, netdev@...r.kernel.org
Cc:     jallen@...ux.vnet.ibm.com, tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Add netdev_dbg output for debugging

On Mon, 2017-08-07 at 15:02 -0400, Nathan Fontenot wrote:
> To ease debugging of the ibmvnic driver add a series of netdev_dbg()
> statements to track driver status, especially during initialization,
> removal, and resetting of the driver.

For some of the function entry logging, it seems
better to use ftrace instead.

> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
[]
> @@ -389,6 +389,8 @@ static int init_stats_token(struct ibmvnic_adapter *adapter)
>  	struct device *dev = &adapter->vdev->dev;
>  	dma_addr_t stok;
>  
> +	netdev_dbg(adapter->netdev, "Initializing stats token\n");

here and subsequent.