netdev - Re: [PATCH] of_mdio: use of_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <080ebcb6-b5aa-63db-176b-83477c2540e5@cogentembedded.com>
Date:   Mon, 7 Aug 2017 19:18:09 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Frank Rowand <frowand.list@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] of_mdio: use of_property_read_u32_array()

Hello!

On 08/07/2017 05:18 PM, Rob Herring wrote:

>> The "fixed-link" prop support predated of_property_read_u32_array(), so
>> basically had to open-code it. Using the modern API saves 24 bytes of the
>> object code (ARM gcc 4.8.5); the only behavior change would be that the
>> prop length check is now less strict (however the strict pre-check done
>> in of_phy_is_fixed_link() is left intact anyway)...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>
>> ---
>> The patch is against the 'dt/next' branch of Rob Herring's 'linux-git' repo
>> plus the previously posted patch killing the useless local variable in
>> of_phy_register_fixed_link().
> 
> It shouldn't depend on anything in my tree and David normally takes
> of_mdio.c changes.

    MAINTAINERS still only point at the DT repo, perhaps it should be updated?

> Reviewed-by: Rob Herring <robh@...nel.org>

    Thank you.

>>   drivers/of/of_mdio.c |   16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)

MBR, Sergei