netdev - Re: [PATCH net 1/1] s390/qeth: fix L3 next-hop in xmit qeth hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170807.112530.1647977400606242335.davem@davemloft.net>
Date:   Mon, 07 Aug 2017 11:25:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        jwi@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, raspl@...ux.vnet.ibm.com
Subject: Re: [PATCH net 1/1] s390/qeth: fix L3 next-hop in xmit qeth hdr

From: Ursula Braun <ubraun@...ux.vnet.ibm.com>
Date: Mon,  7 Aug 2017 13:28:39 +0200

> From: Julian Wiedmann <jwi@...ux.vnet.ibm.com>
> 
> On L3, the qeth_hdr struct needs to be filled with the next-hop
> IP address.
> The current code accesses rtable->rt_gateway without checking that
> rtable is a valid address. The accidental access to a lowcore area
> results in a random next-hop address in the qeth_hdr.
> rtable (or more precisely, skb_dst(skb)) can be NULL in rare cases
> (for instance together with AF_PACKET sockets).
> This patch adds the missing NULL-ptr checks.
> 
> Signed-off-by: Julian Wiedmann <jwi@...ux.vnet.ibm.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.vnet.ibm.com>
> Fixes: 87e7597b5a3 qeth: Move away from using neighbour entries in qeth_l3_fill_header()

Applied.