netdev - Re: [PATCH net] net: sched: set xt_tgchk_param par.net properly in ipt_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 14:00:57 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] net: sched: set xt_tgchk_param par.net properly in ipt_init_target

On Sat, Aug 5, 2017 at 1:48 AM, Xin Long <lucien.xin@...il.com> wrote:
> -static int __tcf_ipt_init(struct tc_action_net *tn, struct nlattr *nla,
> +static int __tcf_ipt_init(struct net *net, struct nlattr *nla,
>                           struct nlattr *est, struct tc_action **a,
>                           const struct tc_action_ops *ops, int ovr, int bind)
>  {
> +       struct tc_action_net *tn = net_generic(net, xt_net_id);

...

> @@ -193,18 +195,14 @@ static int tcf_ipt_init(struct net *net, struct nlattr *nla,
>                         struct nlattr *est, struct tc_action **a, int ovr,
>                         int bind)
>  {
> -       struct tc_action_net *tn = net_generic(net, ipt_net_id);
> -
> -       return __tcf_ipt_init(tn, nla, est, a, &act_ipt_ops, ovr, bind);
> +       return __tcf_ipt_init(net, nla, est, a, &act_ipt_ops, ovr, bind);
>  }
>
>  static int tcf_xt_init(struct net *net, struct nlattr *nla,
>                        struct nlattr *est, struct tc_action **a, int ovr,
>                        int bind)
>  {
> -       struct tc_action_net *tn = net_generic(net, xt_net_id);
> -
> -       return __tcf_ipt_init(tn, nla, est, a, &act_xt_ops, ovr, bind);
> +       return __tcf_ipt_init(net, nla, est, a, &act_xt_ops, ovr, bind);

This is not correct.

You miss ipt_net_id != xt_net_id.