netdev - Re: [PATCH] ip/link_vti*.c: Fix output for ikey/okey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170807153815.7acf5b93@xeon-e3>
Date:   Mon, 7 Aug 2017 15:38:15 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Christian Langrock <christian.langrock@...unet.com>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH] ip/link_vti*.c: Fix output for ikey/okey

On Mon, 7 Aug 2017 11:59:28 +0200
Christian Langrock <christian.langrock@...unet.com> wrote:

> ikey and okey are normal u32 values. There's no reason to print them as
> IPv4/IPv6 addresses.
> 
> Signed-off-by: Christian Langrock <christian.langrock@...unet.com>

Changing output format breaks scripts that parse output.
But on the other hand, the VTI code breaks the assumption that ip command
output should be the same as input.

More likely the original output format was done to match Cisco output.

Why not print in hex like fwmark?

Content of type "application/pgp-signature" skipped