[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2017 12:33:22 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>,
David Miller <davem@...emloft.net>,
netfilter-devel@...r.kernel.org,
Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH net] net: sched: fix NULL pointer dereference when action
calls some targets
On Mon, Aug 7, 2017 at 7:33 PM, Xin Long <lucien.xin@...il.com> wrote:
> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
>> This looks like a completely API burden?
> netfilter xt targets are not really compatible with netsched action.
> I've got to say, the patch is just a way to make checkentry return
> false and avoid panic. like [1] said
I don't doubt you fix a crash, I am thinking if we can
"fix" the API instead of fixing the caller.
I am not familiar with this API, so just my 2 cents...
Powered by blists - more mailing lists