netdev - Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <602fa731-bc27-9748-2b7a-48274be529d9@gmail.com>
Date:   Wed, 9 Aug 2017 08:03:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     Girish Moodalbail <girish.moodalbail@...cle.com>,
        netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default

On 8/9/17 1:38 AM, Girish Moodalbail wrote:
>> @@ -99,7 +95,16 @@ static int nl_dump_ext_err(const struct nlmsghdr
>> *nlh, nl_ext_ack_fn_t errfn)
>>               err_nlh = &err->msg;
>>       }
>>   -    return errfn(errmsg, off, err_nlh);
>> +    if (errfn)
>> +        return errfn(errmsg, off, err_nlh);
>> +
>> +    if (errmsg) {
>> +        fprintf(stderr, "Error: %s\n", errmsg);
> 
> Should the above output end with a period '.'? All the error messages in
> the Kernel are statements without a terminating period, so the output

no guarantee of that, but iproute2 could check for it and add it.