netdev - Re: [PATCHv3 net] net: sched: set xt_tgchk_param par.net properly in ipt_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170808.203858.816888994808276335.davem@davemloft.net>
Date:   Tue, 08 Aug 2017 20:38:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, xiyou.wangcong@...il.com
Subject: Re: [PATCHv3 net] net: sched: set xt_tgchk_param par.net properly
 in ipt_init_target

From: Xin Long <lucien.xin@...il.com>
Date: Tue,  8 Aug 2017 15:25:25 +0800

> Now xt_tgchk_param par in ipt_init_target is a local varibale,
> par.net is not initialized there. Later when xt_check_target
> calls target's checkentry in which it may access par.net, it
> would cause kernel panic.
> 
> Jaroslav found this panic when running:
> 
>   # ip link add TestIface type dummy
>   # tc qd add dev TestIface ingress handle ffff:
>   # tc filter add dev TestIface parent ffff: u32 match u32 0 0 \
>     action xt -j CONNMARK --set-mark 4
> 
> This patch is to pass net param into ipt_init_target and set
> par.net with it properly in there.
> 
> v1->v2:
>   As Wang Cong pointed, I missed ipt_net_id != xt_net_id, so fix
>   it by also passing net_id to __tcf_ipt_init.
> v2->v3:
>   Missed the fixes tag, so add it.
> 
> Fixes: ecb2421b5ddf ("netfilter: add and use nf_ct_netns_get/put")
> Reported-by: Jaroslav Aster <jaster@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.