netdev - Re: [PATCH net] geneve: maximum value of VNI cannot be used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0724a580-49c0-a457-802c-40fde8d040d5@oracle.com>
Date:   Thu, 10 Aug 2017 08:58:58 -0700
From:   Girish Moodalbail <girish.moodalbail@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     pshelar@....org, netdev@...r.kernel.org
Subject: Re: [PATCH net] geneve: maximum value of VNI cannot be used

On 8/9/17 10:41 PM, David Miller wrote:
> From: Girish Moodalbail <girish.moodalbail@...cle.com>
> Date: Tue,  8 Aug 2017 17:26:24 -0700
> 
>> Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range
>> of values for it would be from 0 to 16777215 (2^24 -1).  However, one
>> cannot create a geneve device with VNI set to 16777215. This patch fixes
>> this issue.
>>
>> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>
> 
> I always worry that someone, somewhere, might be using this in some
> way and this will break things.
> 
> But I'll apply this for now.
> 
Thanks David. As per the output of 'ip link help geneve', 16777215 is a valid 
value. However, due to incorrect check in the kernel that value was not supported.

$ ip link help geneve |egrep -A1 VNI
Usage: ... geneve id VNI
                   remote ADDR
--
Where: VNI   := 0-16777215
        ADDR  := IP_ADDRESS

So, this is an off-by-one bug and no one had tripped over it until now.

regards,
~Girish