[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20170809.224721.929007871688762915.davem@davemloft.net>
Date: Wed, 09 Aug 2017 22:47:21 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: lucien.xin@...il.com
Cc: netdev@...r.kernel.org, jiri@...nulli.us, xiyou.wangcong@...il.com
Subject: Re: [PATCHv2 net] net: sched: set xt_tgchk_param par.nft_compat as
0 in ipt_init_target
From: Xin Long <lucien.xin@...il.com>
Date: Wed, 9 Aug 2017 18:15:19 +0800
> Commit 55917a21d0cc ("netfilter: x_tables: add context to know if
> extension runs from nft_compat") introduced a member nft_compat to
> xt_tgchk_param structure.
>
> But it didn't set it's value for ipt_init_target. With unexpected
> value in par.nft_compat, it may return unexpected result in some
> target's checkentry.
>
> This patch is to set all it's fields as 0 and only initialize the
> non-zero fields in ipt_init_target.
>
> v1->v2:
> As Wang Cong's suggestion, fix it by setting all it's fields as
> 0 and only initializing the non-zero fields.
>
> Fixes: 55917a21d0cc ("netfilter: x_tables: add context to know if extension runs from nft_compat")
> Suggested-by: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
Applied and queued up for -stable.
Powered by blists - more mailing lists