lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Aug 2017 22:52:43 -0700 (PDT) From: David Miller <davem@...emloft.net> To: john@...ozen.org Cc: andrew@...n.ch, vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com, sean.wang@...iatek.com, netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, muciri@...nmesh.com, shashidhar.lakkavalli@...nmesh.com Subject: Re: [PATCH 0/4] net-next: dsa: fix flow dissection From: John Crispin <john@...ozen.org> Date: Wed, 9 Aug 2017 14:41:15 +0200 > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch > header and the skb->protocol field is not set up to the correct 802.3 > value yet. By the time the tag specific code is called, removing the header > and properly setting the protocol an invalid hash is already set. In the > case of the mt7530 this will result in all flows always having the same > hash. > > Changes since RFC: > * use a callback instead of static values > * add cover letter Series applied, thanks.
Powered by blists - more mailing lists