netdev - [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170810090720.eh4l6gxsubmwqxo6@mwanda>
Date:   Thu, 10 Aug 2017 12:54:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Yisen Zhuang <yisen.zhuang@...wei.com>
Cc:     Salil Mehta <salil.mehta@...wei.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        lipeng <lipeng321@...wei.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port()

This function has a copy and paste bug so it accidentally calls the add
function instead of the delete function.

Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
index 069ae426aa24..e519795dff7c 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
@@ -1138,7 +1138,7 @@ static void hns3_del_tunnel_port(struct net_device *netdev, u16 port,
 	udp_tnl->dst_port = 0;
 	/* TBD send command to hardware to del port  */
 	if (h->ae_algo->ops->del_tunnel_udp)
-		h->ae_algo->ops->add_tunnel_udp(h, port);
+		h->ae_algo->ops->del_tunnel_udp(h, port);
 }
 
 /* hns3_nic_udp_tunnel_add - Get notifiacetion about UDP tunnel ports