netdev - Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2017 10:56:57 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Benc <jbenc@...hat.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Girish Moodalbail <girish.moodalbail@...cle.com>,
        pravin shelar <pshelar@....org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Matthias Schiffer <mschiffer@...verse-factory.net>
Subject: Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to
 use netlink_ext_ack for error reporting

On 8/11/17 10:39 AM, Jiri Benc wrote:
>>> +       if (!data) {
>>> +               NL_SET_ERR_MSG(extack,
>>> +                              "Not enough attributes provided to perform the operation");
>>>                 return -EINVAL;
>>> +       }
>> "not enough attributes"
> You're missing part of the sentence.
> 

I would argue none of those messages are sufficient. The message should
tell the user what is missing.

What is the point of the !data check anyway? Based on the rest of the
validate function neither IFLA_VXLAN_ID or IFLA_VXLAN_PORT_RANGE are
required attributes.