netdev - Re: [PATCH net-next] geneve: use netlink_ext_ack for error reporting in rtnl operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170811.134514.1496944956776826656.davem@davemloft.net>
Date:   Fri, 11 Aug 2017 13:45:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     girish.moodalbail@...cle.com
Cc:     pshelar@....org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] geneve: use netlink_ext_ack for error
 reporting in rtnl operations

From: Girish Moodalbail <girish.moodalbail@...cle.com>
Date: Wed,  9 Aug 2017 01:09:28 -0700

> Add extack error messages for failure paths while creating/modifying
> geneve devices. Once extack support is added to iproute2, more
> meaningful and helpful error messages will be displayed making it easy
> for users to discern what went wrong.
> 
> Before:
> =======
> $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
>   remote 192.168.13.2
> RTNETLINK answers: Invalid argument
> 
> After:
> ======
> $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
>   remote 192.168.13.2
> Error: Provided link layer address is not Ethernet
> 
> Also, netdev_dbg() calls used to log errors associated with Netlink
> request have been removed.
> 
> Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com>

Applied, thanks.