netdev - Re: [PATCH 3/3] tls: Use correct sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170811.143623.1591561982680569459.davem@davemloft.net>
Date:   Fri, 11 Aug 2017 14:36:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ilyal@...lanox.com
Cc:     netdev@...r.kernel.org, davejwatson@...com, aviadye@...lanox.com,
        borisp@...lanox.com
Subject: Re: [PATCH 3/3] tls: Use correct sk->sk_prot for IPV6

From: Ilya Lesokhin <ilyal@...lanox.com>
Date: Thu, 10 Aug 2017 13:33:16 +0300

> +#if IS_ENABLED(CONFIG_IPV6)
> +	build_protos(tls_prots[TLSV6], &tcpv6_prot);
> +#endif
>  

Have you tested this with CONFIG_TLS=m and CONFIG_IPV6=m?

I bet it doesn't link.

How about CONFIG_IPV6=m and CONFIG_TLS=y?  That won't
work either.

In fact TLS has no Kconfig dependency whatsoever on IPV6.