lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Aug 2017 10:29:55 +0800 From: Tonghao Zhang <xiangxia.m.yue@...il.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com> Cc: Network Development <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>, Willem de Bruijn <willemb@...gle.com> Subject: Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_NONE check for tx. Hi Willem, because we change the CHECKSUM_NONE to CHECKSUM_UNNECESSARY in skb_needs_check(), I can't revert 6e7bc478c9a0 ("net: skb_needs_check() accepts CHECKSUM_NONE for tx"). I change it directly and resubmit it. On Fri, Aug 11, 2017 at 1:03 AM, Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote: > On Wed, Aug 9, 2017 at 6:02 PM, Tonghao Zhang <xiangxia.m.yue@...il.com> wrote: >> Thanks for your work. > > You, too. > >> On Thu, Aug 10, 2017 at 2:30 AM, Willem de Bruijn >> <willemdebruijn.kernel@...il.com> wrote: >>> On Wed, Aug 9, 2017 at 5:04 AM, Tonghao Zhang <xiangxia.m.yue@...il.com> wrote: >>>> This patch reverts the commit 6e7bc478c9a0 >>>> ("net: skb_needs_check() accepts CHECKSUM_NONE for tx"), >>>> because we removed the UFO support. >>>> >>>> Cc: Eric Dumazet <edumazet@...gle.com> >>>> Cc: Willem de Bruijn <willemb@...gle.com> >>>> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com> >>> >>> >>> I would wait until net is merged into net-next. This will cause a conflict. >>> >>> Also, while logically equivalent, it is not a real revert (as in `git >>> revert $SHA1`) of that patch. >>> >>> Aside from those concerns, I agree that the original patch is no >>> longer needed now that UFO is reverted. > > Please do resubmit the revert patch once net has been merged into net-next.
Powered by blists - more mailing lists