netdev - Re: [PATCH net-next 1/3] Add LAN743X driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170811155908.04d9eb4c@xeon-e3>
Date:   Fri, 11 Aug 2017 15:59:08 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     <Bryan.Whitehead@...rochip.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next 1/3] Add LAN743X driver

On Fri, 11 Aug 2017 19:47:57 +0000
<Bryan.Whitehead@...rochip.com> wrote:

> +static void lan743x_pcidev_remove(struct pci_dev *pdev)
> +{
> +	struct net_device *netdev = NULL;
> +	struct lan743x_adapter *adapter = NULL;
> +
> +	netdev = pci_get_drvdata(pdev);
> +	adapter = netdev_priv(netdev);

Useless double initialization