netdev - Re: [PATCH] selftests: bpf: add check for ip XDP redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <598D9597.2030907@iogearbox.net>
Date:   Fri, 11 Aug 2017 13:31:35 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     William Tu <u9012063@...il.com>, netdev@...r.kernel.org
CC:     John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH] selftests: bpf: add check for ip XDP redirect

On 08/11/2017 02:02 AM, William Tu wrote:
> Kernel test robot reports error when running test_xdp_redirect.sh.
> Check if ip tool supports xdpgeneric, if not, skip the test.
>
> Signed-off-by: William Tu <u9012063@...il.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: John Fastabend <john.fastabend@...il.com>
> ---
>   tools/testing/selftests/bpf/test_xdp_redirect.sh | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_xdp_redirect.sh b/tools/testing/selftests/bpf/test_xdp_redirect.sh
> index d8c73ed6e040..c5a8b7173c12 100755
> --- a/tools/testing/selftests/bpf/test_xdp_redirect.sh
> +++ b/tools/testing/selftests/bpf/test_xdp_redirect.sh
> @@ -23,6 +23,11 @@ cleanup()
>   	ip netns del ns2 2> /dev/null
>   }
>
> +ip link set dev lo xdpgeneric off 2>/dev/null > /dev/null
> +if [ $? -ne 0 ];then
> +        echo "selftests: [SKIP] Could not run test without the ip xdpgeneric support"
> +        exit 0

Small nit: could you make that indent consistently as tabs
like in your cleanup() function slightly further above?

Other than that (+ subject should also be [PATCH net-next]):

Acked-by: Daniel Borkmann <daniel@...earbox.net>