netdev - Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170811174731.51b71c65@griffin>
Date:   Fri, 11 Aug 2017 17:47:31 +0200
From:   Jiri Benc <jbenc@...hat.com>
To:     Girish Moodalbail <girish.moodalbail@...cle.com>
Cc:     <pshelar@....org>, <davem@...emloft.net>, <netdev@...r.kernel.org>,
        mschiffer@...verse-factory.net, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to
 use netlink_ext_ack for error reporting

On Thu, 10 Aug 2017 14:16:35 -0700, Girish Moodalbail wrote:
> +			NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_PORT_RANGE],
> +					    "Provided source port range bounds is invalid");

s/bounds//?

> +	if (conf->label && !use_ipv6) {
> +		NL_SET_ERR_MSG(extack,
> +			       "Label attribute only applies for IPv6 VXLAN devices");

applies to

> +		if (!lowerdev) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Specified interface for tunnel endpoint communications not found");

s/communications//?

> +		if (vxlan_addr_multicast(&conf->remote_ip)) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Interface need to be specified for multicast destination");

needs

> +		if (conf->flags & VXLAN_F_IPV6_LINKLOCAL) {
> +			NL_SET_ERR_MSG(extack,
> +				       "Interface need to be specified for link-local local/remote addresses");

needs

Looks good to me otherwise, thanks!

 Jiri