netdev - Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <351cfa76-3fba-ffd0-3deb-e65eadf88223@universe-factory.net>
Date:   Fri, 11 Aug 2017 18:24:00 +0200
From:   Matthias Schiffer <mschiffer@...verse-factory.net>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     Girish Moodalbail <girish.moodalbail@...cle.com>,
        pravin shelar <pshelar@....org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to
 use netlink_ext_ack for error reporting

On 08/11/2017 06:19 PM, Roopa Prabhu wrote:
> On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail
> <girish.moodalbail@...cle.com> wrote:
>>
>>                 if (!is_valid_ether_addr(nla_data(tb[IFLA_ADDRESS]))) {
>> -                       pr_debug("invalid all zero ethernet address\n");
>> +                       NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_ADDRESS],
>> +                                           "Provided Ethernet address is not unicast");
>>                         return -EADDRNOTAVAIL;
> 
> 
> keep it simple and closer to the original msg: "invalid all zero
> ethernet address"

It is inaccurate though, is_valid_ether_addr will also reject multicast
addresses.

Matthias



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)