netdev - Re: [net-next 01/15] i40e/i40evf: fix some minor type mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170812.130118.1497247269239499736.davem@davemloft.net>
Date:   Sat, 12 Aug 2017 13:01:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     jesse.brandeburg@...el.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 01/15] i40e/i40evf: fix some minor type mismatches

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 12 Aug 2017 04:08:33 -0700

> @@ -1830,7 +1830,7 @@ static struct sk_buff *i40e_construct_skb(struct i40e_ring *rx_ring,
>  	/* prefetch first cache line of first page */
>  	prefetch(xdp->data);
>  #if L1_CACHE_BYTES < 128
> -	prefetch(xdp->data + L1_CACHE_BYTES);
> +	prefetch((void *)(xdp->data + L1_CACHE_BYTES));
>  #endif

This cast seems unnecessary:

[davem@...alhost net]$ cat x.c
extern void foo(const void *x);

void bar(void *x)
{
	foo(x);
}
[davem@...alhost net]$ gcc -Wall -O2 -c -o x.o x.c
[davem@...alhost net]$