netdev - Re: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170812.130405.1462747317744893185.davem@davemloft.net>
Date:   Sat, 12 Aug 2017 13:04:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     jacob.e.keller@...el.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 08/15] i40e/i40evf: organize and re-number feature
 flags

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 12 Aug 2017 04:08:41 -0700

> Also ensure that the flags variable is actually a u64 to guarantee
> 64bits of space on all architectures.

Why?  You don't need 64-bits, you only need 27.

This will be unnecessarily expensive on 32-bit platforms.

Please don't do this.