netdev - Re: [PATCH net] ipv6: release rt6->rt6i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e1bb883-8d44-fcf6-4d2e-6c1ccd0ca95e@gmail.com>
Date:   Mon, 14 Aug 2017 13:05:16 -0600
From:   David Ahern <dsahern@...il.com>
To:     Wei Wang <weiwan@...gle.com>, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org
Cc:     Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH net] ipv6: release rt6->rt6i_idev properly during ifdown

On 8/14/17 11:44 AM, Wei Wang wrote:
> From: Wei Wang <weiwan@...gle.com>
> 
> When a dst is created by addrconf_dst_alloc() for a host route or an
> anycast route, dst->dev points to loopback dev while rt6->rt6i_idev
> points to a real device.
> When the real device goes down, the current cleanup code only checks for
> dst->dev and assumes rt6->rt6i_idev->dev is the same. This causes the
> refcount leak on the real device in the above situation.
> This patch makes sure to always release the refcount taken on
> rt6->rt6i_idev during dst_dev_put().
> 
> Fixes: 587fea741134 ("ipv6: mark DST_NOGC and remove the operation of
> dst_free()")
> Reported-by: John Stultz <john.stultz@...aro.org>
> Tested-by: John Stultz <john.stultz@...aro.org>
> Tested-by: Martin KaFai Lau <kafai@...com>
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---
>  net/ipv6/route.c | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)

Acked-by: David Ahern <dsahern@...il.com>