netdev - Re: [PATCH net-next 05/11] net: dsa: debugfs: add port stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170814224546.GB16885@lunn.ch>
Date:   Tue, 15 Aug 2017 00:45:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Egil Hjelmeland <privat@...l-hjelmeland.no>,
        John Crispin <john@...ozen.org>,
        Woojung Huh <Woojung.Huh@...rochip.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Volodymyr Bendiuga <volodymyr.bendiuga@...il.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Maxime Hadjinlian <maxime@...ialet.com>,
        Chris Healy <cphealy@...il.com>,
        Maxim Uvarov <muvarov@...il.com>,
        Stefan Eichenberger <eichest@...il.com>,
        Jason Cobham <jcobham@...stertangent.com>,
        Juergen Borleis <jbe@...gutronix.de>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH net-next 05/11] net: dsa: debugfs: add port stats

On Mon, Aug 14, 2017 at 06:22:36PM -0400, Vivien Didelot wrote:
> Add a debug filesystem "stats" entry to query a port's hardware
> statistics through the DSA switch .get_sset_count, .get_strings and
> .get_ethtool_stats operations.
> 
> This allows one to get statistics about DSA links interconnecting
> switches, which is very convenient because this kind of port is not
> exposed to userspace.
> 
> Here are the stats of a zii-rev-b DSA and CPU ports:
> 
>     # pr -mt switch0/port{5,6}/stats
>     in_good_octets      : 0             in_good_octets      : 13824
>     in_bad_octets       : 0             in_bad_octets       : 0
>     in_unicast          : 0             in_unicast          : 0
>     in_broadcasts       : 0             in_broadcasts       : 216
>     in_multicasts       : 0             in_multicasts       : 0
>     in_pause            : 0             in_pause            : 0
>     in_undersize        : 0             in_undersize        : 0
>     in_fragments        : 0             in_fragments        : 0
>     in_oversize         : 0             in_oversize         : 0
>     in_jabber           : 0             in_jabber           : 0
>     in_rx_error         : 0             in_rx_error         : 0
>     in_fcs_error        : 0             in_fcs_error        : 0
>     out_octets          : 9216          out_octets          : 0
>     out_unicast         : 0             out_unicast         : 0
>     out_broadcasts      : 144           out_broadcasts      : 0
>     out_multicasts      : 0             out_multicasts      : 0
>     out_pause           : 0             out_pause           : 0
>     excessive           : 0             excessive           : 0
>     collisions          : 0             collisions          : 0
>     deferred            : 0             deferred            : 0
>     single              : 0             single              : 0
>     multiple            : 0             multiple            : 0
>     out_fcs_error       : 0             out_fcs_error       : 0
>     late                : 0             late                : 0
>     hist_64bytes        : 0             hist_64bytes        : 0
>     hist_65_127bytes    : 0             hist_65_127bytes    : 0
>     hist_128_255bytes   : 0             hist_128_255bytes   : 0
>     hist_256_511bytes   : 0             hist_256_511bytes   : 0
>     hist_512_1023bytes  : 0             hist_512_1023bytes  : 0
>     hist_1024_max_bytes : 0             hist_1024_max_bytes : 0
>     sw_in_discards      : 0             sw_in_discards      : 0
>     sw_in_filtered      : 0             sw_in_filtered      : 0
>     sw_out_filtered     : 0             sw_out_filtered     : 216
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew