netdev - Re: [PATCH] of_mdio: merge branch tails in of_phy_register_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170813.200908.1426365653542179792.davem@davemloft.net>
Date:   Sun, 13 Aug 2017 20:09:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sergei.shtylyov@...entembedded.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, robh+dt@...nel.org,
        frowand.list@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] of_mdio: merge branch tails in
 of_phy_register_fixed_link()

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Sun, 13 Aug 2017 00:03:06 +0300

> Looks  like gcc isn't always able to figure  out that 3 *if* branches in
> of_phy_register_fixed_link() calling fixed_phy_register() at their ends
> are similar enough and thus can be merged. The "manual" merge saves 40
> bytes of the object code (AArch64 gcc 4.8.5), and still saves 12 bytes
> even  if gcc was able to merge the branch tails (ARM gcc 4.8.5)...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied, but if two instances of the "same" compiler just with
different targets changes the optimization, it could be because of a
tradeoff which is specific to parameters expressed in that target's
backend.

So in the future we should probably back away from trying to "help"
the compiler in this way.