netdev - Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170814070052.GB1855@nanopsycho>
Date:   Mon, 14 Aug 2017 09:00:52 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Ohad Oz <ohado@...lanox.com>, davem@...emloft.net,
        netdev@...r.kernel.org, saeedm@...lanox.com, vadimp@...lanox.com,
        system-sw-low-level@...lanox.com
Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if
 only I2C bus is configured

Sat, Aug 12, 2017 at 04:37:15PM CEST, leon@...nel.org wrote:
>On Thu, Aug 10, 2017 at 05:11:51PM +0000, Ohad Oz wrote:
>> Patch allows Mellanox devices on system with no PCI, but with I2C only.
>>
>
>Did you test mlx5 device on such system? Did it work for you?

$ git grep i2c_add_driver drivers/net/ethernet/mellanox/
drivers/net/ethernet/mellanox/mlxsw/i2c.c:      return i2c_add_driver(i2c_driver);

That is the only driver that would probe on i2c, non-pci system.
mlx5 just would not probe, so there is nothing to test.



>
>What is the changelog between v0 and v1 of these patches?
>
>
>> Signed-off-by: Ohad Oz <ohado@...lanox.com>
>> ---
>>  drivers/net/ethernet/mellanox/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/Kconfig b/drivers/net/ethernet/mellanox/Kconfig
>> index 84a2007..0949741 100644
>> --- a/drivers/net/ethernet/mellanox/Kconfig
>> +++ b/drivers/net/ethernet/mellanox/Kconfig
>> @@ -5,7 +5,7 @@
>>  config NET_VENDOR_MELLANOX
>>  	bool "Mellanox devices"
>>  	default y
>> -	depends on PCI
>> +	depends on PCI || I2C
>>  	---help---
>>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>>
>> --
>> 2.8.0
>>