netdev - RE: [PATCH net-next 1/3] Add LAN743X driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90A7E81AE28BAE4CBDDB3B35F187D264406F66D0@CHN-SV-EXMX02.mchp-main.com>
Date:   Mon, 14 Aug 2017 16:15:29 +0000
From:   <Bryan.Whitehead@...rochip.com>
To:     <stephen@...workplumber.org>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-next 1/3] Add LAN743X driver

> 
> The statistics code here is confused.
> You are already counting rx_packets in software in napi_poll Then you get
> values from MAC. One or the other?
> There are two copies of stats, one in netdev and other in your mac structure.
> 
> Also what about byte and error counts?
> 
> If possible implement 64 bit get_stats64 instead.

Stephen,

Thanks for the feedback.

I will work on your suggestions, and submit again later.

Bryan