netdev - Re: [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170815140048.GA1836@nanopsycho>
Date:   Tue, 15 Aug 2017 16:00:48 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH] net_sched: reset pointers to tcf blocks in classful
 qdiscs' destructors

Tue, Aug 15, 2017 at 03:35:21PM CEST, khlebnikov@...dex-team.ru wrote:
>Traffic filters could keep direct pointers to classes in classful qdisc,
>thus qdisc destruction first removes all filters before freeing classes.
>Class destruction methods also tries to free attached filters but now
>this isn't safe because tcf_block_put() unlike to tcf_destroy_chain()
>cannot be called second time.
>
>This patch set class->block to NULL after first tcf_block_put() and
>turn second call into no-op.
>
>Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
>Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!