netdev - Re: [PATCH 2/5] net/9p: Improve 19 size determinations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2017 15:21:53 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Van Hensbergen <ericvh@...il.com>,
        Latchesar Ionkov <lucho@...kov.net>,
        Ron Minnich <rminnich@...dia.gov>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/5] net/9p: Improve 19 size determinations

On Tue, Aug 15, 2017 at 02:00:06PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 15 Aug 2017 09:36:20 +0200
> 
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.

Garbage.  This makes it so much harder to find where the objects of given
type are created.  It's _not_ safer and any patches of that sort around
VFS will be shitcanned.  What to do with net/9p patches is up to net/9p
maintainers, but I would strongly recommend the same treatment.