netdev - Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502808649.4936.80.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 15 Aug 2017 07:50:49 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH] net_sched/sfq: update hierarchical backlog when drop
 packet

On Tue, 2017-08-15 at 17:33 +0300, Konstantin Khlebnikov wrote:

> Nope. I'm not sure. But we have something similar in our 4.4 kernel
> for a while.
> 
> Also fq_codel and pfifo_head_drop do something similar tho this.
> 
> Probably this might crash without "[PATCH 1/2] net_sched: call
> qlen_notify only if child qdisc is empty".
> I hadn't tested them separately.

Thanks for the info. I've read this patch and it looks fine indeed :)

Acked-by: Eric Dumazet <edumazet@...gle.com>