netdev - Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fac1100-c7d3-85ed-8230-53e6ffb3df0a@infradead.org>
Date:   Tue, 15 Aug 2017 09:41:53 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Neal Cardwell <ncardwell@...gle.com>,
        mohamedalrshah <mohamed.a.alrshah@...e.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mohamed Othman <mothman@....edu.my>,
        Borhanuddin Ali <borhan@....edu.my>,
        Zurina Hanapi <zurinamh@....edu.my>
Subject: Re: [PATCH]
 Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

On 08/15/2017 06:51 AM, Neal Cardwell wrote:
> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
> <mohamed.a.alrshah@...e.org> wrote:
> 
>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>> +{
>> +       struct tcp_sock *tp = tcp_sk(sk);
>> +       struct agilesdtcp *ca = inet_csk_ca(sk);
>> +       u32 inc_factor;
>> +       u32 ca_inc;
>> +       u32 current_gap, total_gap;
> 
> For coding style, please order local variable declarations from
> longest to shortest line, also know as Reverse Christmas Tree Format.

Per what coding style, please?  This is not in current coding style nor in the
netdev-FAQ exceptions.


-- 
~Randy