netdev - Re: [PATCH net] tcp: ulp: avoid module refcnt leak in tcp_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170814.221737.507862199447270473.davem@davemloft.net>
Date:   Mon, 14 Aug 2017 22:17:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, davejwatson@...com, borisp@...lanox.com,
        tom@...ntonium.net, hannes@...essinduktion.org
Subject: Re: [PATCH net] tcp: ulp: avoid module refcnt leak in tcp_set_ulp

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Mon, 14 Aug 2017 18:04:24 +0200

> __tcp_ulp_find_autoload returns tcp_ulp_ops after taking a reference on
> the module. Then, if ->init fails, tcp_set_ulp propagates the error but
> nothing releases that reference.
> 
> Fixes: 734942cc4ea6 ("tcp: ULP infrastructure")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks.