netdev - Re: [PATCH] i40e{,vf}: Fix out-of-bound cpumask read in IRQ affinity handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170815123348.711b1680@elisabeth>
Date:   Tue, 15 Aug 2017 12:33:48 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        Alan Brady <alan.brady@...el.com>,
        Stefan Assmann <sassmann@...hat.com>
Subject: Re: [PATCH] i40e{,vf}: Fix out-of-bound cpumask read in IRQ
 affinity handler

On Tue, 15 Aug 2017 12:30:14 +0200
Stefano Brivio <sbrivio@...hat.com> wrote:

> The cpumask used in i40e{,vf}_irq_affinity_notify() is allocated
> by irq_affinity_notify() with alloc_cpumask_var(), which doesn't
> allocate NR_CPUS bits, but only nr_cpumask_bits bits. If we just
> dereference it, we'll read way more than what is allocated, e.g.
> 1024 bytes vs. 8 bytes allocated on x86_64 machine with 24 CPUs.

Sorry, just two minutes after sending this I noticed Juergen submitted
the same fixes on Saturday:

From: Juergen Gross <jgross@...e.com>
To: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,         intel-wired-lan@...ts.osuosl.org
Cc: jeffrey.t.kirsher@...el.com, Juergen Gross <jgross@...e.com>,         stable@...r.kernel.org
Subject: [PATCH] net/i40e: use cpumask_copy() for assigning cpumask
Date: Sat, 12 Aug 2017 18:09:46 +0200

Please discard.

--
Stefano