netdev - Re: [PATCH] net/i40e: use cpumask_copy() for assigning cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170816115233.6cc33078@elisabeth>
Date:   Wed, 16 Aug 2017 11:52:33 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] net/i40e: use cpumask_copy() for assigning cpumask

Hi Juergen,

On Sat, 12 Aug 2017 18:09:46 +0200
Juergen Gross <jgross@...e.com> wrote:

> Using direct assignment for a cpumask is wrong, cpumask_copy() should
> be used instead.

Perhaps a Fixes: tag might be helpful here, such as:

	Fixes: 96db776a3682 ("i40e/i40evf: fix interrupt affinity bug")

as I reported in my other (late) patch:

	http://marc.info/?l=linux-netdev&m=150279303222066&w=2

> Cc: stable@...r.kernel.org

and maybe also an indication about which versions this applies to, such as

Cc: stable@...r.kernel.org # 4.10+

In general, feel free to copy from my commit message.

These comments also apply to:

	[PATCH] net/i40evf: use cpumask_copy() for assigning cpumask

Thanks,


--
Stefano