netdev - Re: [PATCH 1/2] net_sched: call qlen_notify only if child qdisc is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170816.105657.1279204691313415545.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 10:56:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     khlebnikov@...dex-team.ru
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com, jkosina@...e.cz,
        edumazet@...gle.com, jhs@...atatu.com
Subject: Re: [PATCH 1/2] net_sched: call qlen_notify only if child qdisc is
 empty

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Tue, 15 Aug 2017 16:39:59 +0300

> This callback is used for deactivating class in parent qdisc.
> This is cheaper to test queue length right here.
> 
> Also this allows to catch draining screwed backlog and prevent
> second deactivation of already inactive parent class which will
> crash kernel for sure. Kernel with print warning at destruction
> of child qdisc where no packets but backlog is not zero.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

Applied.