netdev - Re: [net-next PATCH] bpf: devmap: remove unnecessary value size check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170816.113534.473760745011942655.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 11:35:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     john.fastabend@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [net-next PATCH] bpf: devmap: remove unnecessary value size
 check

From: John Fastabend <john.fastabend@...il.com>
Date: Tue, 15 Aug 2017 23:35:12 -0700

> In the devmap alloc map logic we check to ensure that the sizeof the
> values are not greater than KMALLOC_MAX_SIZE. But, in the dev map case
> we ensure the value size is 4bytes earlier in the function because all
> values should be netdev ifindex values.
> 
> The second check is harmless but is not needed so remove it.
> 
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Applied.