netdev - Re: [net-next PATCH 00/10] BPF: sockmap and sk redirect support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170816.121305.1824274693019781357.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 12:13:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     john.fastabend@...il.com
Cc:     daniel@...earbox.net, ast@...com, tgraf@...g.ch,
        netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [net-next PATCH 00/10] BPF: sockmap and sk redirect support

From: John Fastabend <john.fastabend@...il.com>
Date: Wed, 16 Aug 2017 12:06:36 -0700

> On 08/16/2017 11:35 AM, David Miller wrote:
>> From: David Miller <davem@...emloft.net>
>> Date: Wed, 16 Aug 2017 11:28:19 -0700 (PDT)
>> 
>>> From: John Fastabend <john.fastabend@...il.com>
>>> Date: Tue, 15 Aug 2017 22:30:15 -0700
>>>
>>>> This series implements a sockmap and socket redirect helper for BPF
>>>> using a model similar to XDP netdev redirect.
>>>
>>> Series applied, thanks John.
>>>
>> 
>> We get a legit warning from gcc due to these changes:
>> 
>> kernel/bpf/sockmap.c: In function ‘smap_state_change’:
>> kernel/bpf/sockmap.c:156:21: warning: ‘psock’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>   struct smap_psock *psock;
>> 
>> It's the default switch case in this function, psock is not initialized
>> for sure at this point.
>> 
> 
> I missed this with older gcc4 it seems. Fixed now and compiling without errors
> now with gcc4/5. Below is the diff and all verifier/sockmap tests pass. Want a
> v2 I presume?

I already pushed out v1, so you'll need to send me a fixup patch.