netdev - Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816201707.xbpquud3ar3uarst@sasha-lappy>
Date:   Wed, 16 Aug 2017 20:13:02 +0000
From:   "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

Ping?

On Thu, Jul 27, 2017 at 02:13:52PM -0400, Sasha Levin wrote:
>This is useful for directly looking up a task based on class id rather than
>having to scan through all open file descriptors.
>
>Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
>---
>
>Changes in V2:
> - Addressed comments from Cong Wang (use nla_put_u32())
>
> include/uapi/linux/inet_diag.h |  1 +
> net/ipv4/inet_diag.c           | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
>diff --git a/include/uapi/linux/inet_diag.h b/include/uapi/linux/inet_diag.h
>index bbe201047df6..678496897a68 100644
>--- a/include/uapi/linux/inet_diag.h
>+++ b/include/uapi/linux/inet_diag.h
>@@ -142,6 +142,7 @@ enum {
> 	INET_DIAG_PAD,
> 	INET_DIAG_MARK,
> 	INET_DIAG_BBRINFO,
>+	INET_DIAG_CLASS_ID,
> 	__INET_DIAG_MAX,
> };
>
>diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
>index 3828b3a805cd..2c2445d4bb58 100644
>--- a/net/ipv4/inet_diag.c
>+++ b/net/ipv4/inet_diag.c
>@@ -274,6 +274,16 @@ int inet_sk_diag_fill(struct sock *sk, struct inet_connection_sock *icsk,
> 			goto errout;
> 	}
>
>+	if (ext & (1 << (INET_DIAG_CLASS_ID - 1))) {
>+		u32 classid = 0;
>+
>+#ifdef CONFIG_SOCK_CGROUP_DATA
>+		classid = sock_cgroup_classid(&sk->sk_cgrp_data);
>+#endif
>+
>+		nla_put_u32(skb, INET_DIAG_CLASS_ID, classid);
>+	}
>+
> out:
> 	nlmsg_end(skb, nlh);
> 	return 0;
>-- 
>2.11.0

-- 

Thanks,
Sasha