netdev - Re: [net-next PATCH 1/2] bpf: sockmap state change warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5994C2E6.2010304@iogearbox.net>
Date:   Thu, 17 Aug 2017 00:10:46 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, davem@...emloft.net,
        eric.dumazet@...il.com, dsahern@...il.com
CC:     netdev@...r.kernel.org
Subject: Re: [net-next PATCH 1/2] bpf: sockmap state change warning fix

On 08/17/2017 12:02 AM, John Fastabend wrote:
> psock will uninitialized in default case we need to do the same psock lookup
> and check as in other branch. Fixes compile warning below.
>
> kernel/bpf/sockmap.c: In function ‘smap_state_change’:
> kernel/bpf/sockmap.c:156:21: warning: ‘psock’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    struct smap_psock *psock;
>
> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
> Reported-by: David Miller <davem@...emloft.net>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Thanks for fixing up quickly!

Acked-by: Daniel Borkmann <daniel@...earbox.net>