netdev - Re: [net-next PATCH 07/10] bpf: add access to sock fields and pkt data from sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59958EBC.6070502@iogearbox.net>
Date:   Thu, 17 Aug 2017 14:40:28 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <ast@...com>,
        John Fastabend <john.fastabend@...il.com>, davem@...emloft.net
CC:     tgraf@...g.ch, netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [net-next PATCH 07/10] bpf: add access to sock fields and pkt
 data from sk_skb programs

On 08/17/2017 07:42 AM, Alexei Starovoitov wrote:
> On 8/15/17 10:33 PM, John Fastabend wrote:
>> +static int sk_skb_prologue(struct bpf_insn *insn_buf, bool direct_write,
>> +               const struct bpf_prog *prog)
>> +{
>> +    struct bpf_insn *insn = insn_buf;
>> +
>> +    if (!direct_write)
>> +        return 0;
>> +
>> +    /* if (!skb->cloned)
>> +     *       goto start;
>> +     *
>> +     * (Fast-path, otherwise approximation that we might be
>> +     *  a clone, do the rest in helper.)
>> +     */
>
> iirc we're doing something similar in other prologue generator?
> can be consolidated?

Jup, with tc. I'll fix this one so the two can be consolidated.

Cheers,
Daniel