netdev - Re: [PATCH v4 3/4] dt-bindings: can: m_can: Document new can transceiver binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817140642.q6wxp2d6ss5h3yrp@rob-hp-laptop>
Date:   Thu, 17 Aug 2017 10:10:39 -0500
From:   Rob Herring <robh@...nel.org>
To:     Franklin S Cooper Jr <fcooper@...com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de,
        quentin.schulz@...e-electrons.com, dev.kurt@...dijck-laurijssen.be,
        andrew@...n.ch, sergei.shtylyov@...entembedded.com,
        socketcan@...tkopp.net
Subject: Re: [PATCH v4 3/4] dt-bindings: can: m_can: Document new can
 transceiver binding

On Wed, Aug 09, 2017 at 07:59:15PM -0500, Franklin S Cooper Jr wrote:
> Add information regarding can-transceiver binding. This is especially
> important for MCAN since the IP allows CAN FD mode to run significantly
> faster than what most transceivers are capable of.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
> ---
> Drop unit address.
> Switch from using fixed-transceiver to can-transceiver
> Indicate that can-transceiver is an optional subnode not a property.
> 
>  Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
> index 9e33177..ee90aac 100644
> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
> @@ -43,6 +43,11 @@ Required properties:
>  			  Please refer to 2.4.1 Message RAM Configuration in
>  			  Bosch M_CAN user manual for details.
>  
> +Optional Subnode:
> +- can-transceiver	: Can-transceiver subnode describing maximum speed
> +			  that can be used for CAN/CAN-FD modes. See
> +			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
> +			  for details.
>  Example:
>  SoC dtsi:
>  m_can1: can@...e8000 {
> @@ -64,4 +69,8 @@ Board dts:
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_m_can1>;
>  	status = "enabled";
> +
> +	can-transceiver@ {

ditto

Acked-by: Rob Herring <robh@...nel.org>

> +		max-bitrate = <5000000>;
> +	};
>  };
> -- 
> 2.9.4.dirty
>