netdev - Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170817151025.sdbusesfq7spy4fm@rob-hp-laptop>
Date:   Thu, 17 Aug 2017 10:10:25 -0500
From:   Rob Herring <robh@...nel.org>
To:     "David.Wu" <david.wu@...k-chips.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>, davem@...emloft.net,
        heiko@...ech.de, mark.rutland@....com, catalin.marinas@....com,
        will.deacon@....com, olof@...om.net, linux@...linux.org.uk,
        arnd@...db.de, peppe.cavallaro@...com, alexandre.torgue@...com,
        huangtao@...k-chips.com, hwg@...k-chips.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal
 binding

On Thu, Aug 10, 2017 at 06:57:40PM +0800, David.Wu wrote:
> Hi Andrew, Florian
> 
> 在 2017/8/10 8:20, Andrew Lunn 写道:
> > Hi Florian, David.
> > 
> > I'm happy with the property name. But i think the text needs more
> > description. We deal with Ethernet switches with integrated PHYs. Yet
> > for us, this property is unneeded.
> > 
> > Seeing this property means some bit of software needs to ensure the
> > internal PHY should be used, when given the choice between an internal
> > and external PHY. So i would say something like:
> > 
> >      If set, indicates that the PHY is integrated into the same
> >      physical package as the Ethernet MAC. If needed, muxers should be
> >      configured to ensure the (internal) PHY is used. The absence of this
> >      property indicates the muxers should be configured so that the
> >      external PHY is used.
> 
> Are we supposed to replace the words "internal" with "integrated" here?
> So we have three kinds of PHY, they are intenal, external and integrated
> PHYs.

And you can have both a XAUI/serdes phy and the ethernet phy. It should 
be clear this is for the latter.

Rob