netdev - Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170817.100401.864010589587308706.davem@davemloft.net>
Date:   Thu, 17 Aug 2017 10:04:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     decui@...rosoft.com
Cc:     jhansen@...are.com, netdev@...r.kernel.org,
        gregkh@...uxfoundation.org, devel@...uxdriverproject.org,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        georgezhang@...are.com, mkubecek@...e.cz, asias@...hat.com,
        stefanha@...hat.com, vkuznets@...hat.com, cavery@...hat.com,
        jasowang@...hat.com, rolf.neugebauer@...ker.com,
        dave.scott@...ker.com, marcelo.cerri@...onical.com,
        apw@...onical.com, olaf@...fle.de, joe@...ches.com,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH] vsock: only load vmci transport on VMware hypervisor
 by default

From: Dexuan Cui <decui@...rosoft.com>
Date: Thu, 17 Aug 2017 08:00:29 +0000

> @@ -73,6 +74,10 @@ struct vmci_transport_recv_pkt_info {
>  	struct vmci_transport_packet pkt;
>  };
>  
> +static bool skip_hypervisor_check;
> +module_param(skip_hypervisor_check, bool, 0444);
> +MODULE_PARM_DESC(hot_add, "If set, attempt to load on non-VMware platforms");
> +

I would avoid module parameters at all costs.

It is the worst possible interface for users of your software.

You really need to fundamentally solve the problems related to making
sure the proper modules for the VM actually present on the system get
loaded when necessary rather than adding hacks like this.

Unlike a proper solution, these hacks are ugly but have to stay around
forever once you put them in place.