netdev - Re: [PATCH net-next] net: check type when freeing metadata dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a983211c-530a-8f73-ed00-c95840ce3d08@cogentembedded.com>
Date:   Fri, 18 Aug 2017 15:25:53 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Lamparter <equinox@...c24.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>,
        Simon Horman <horms@...ge.net.au>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: check type when freeing metadata dst

Hello!

On 08/18/2017 03:16 PM, David Lamparter wrote:

> There is a new metadata dst type field added in "net: store
> port/representator id in metadata_dst", but metadata_dst_free() wasn't
> updated to check it before freeing the METADATA_IP_TUNNEL specific dst
> cache entry.
> 
> This is not currently causing problems since it's far enough back in the
> struct to be zeroed for the only other type currently in existance
> (METADATA_HW_PORT_MUX), but nevertheless it's not correct.
> 
> Fixes: 3fcece12bc1b6dcdf0986f2cd9e8f63b1f9b6aa0

    Please see Documentation/process/submitting-patches.rst on how this tag 
(and the commit citing in your description as well) should look like.

> Signed-off-by: David Lamparter <equinox@...c24.net>
> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Cc: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Cc: Simon Horman <horms@...ge.net.au>
> Cc: David S. Miller <davem@...emloft.net>

[...]

MBR, Sergei