netdev - Re: [iproute PATCH v2 1/7] ipaddress: Make buffer for filter.flushb static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170818085519.5a81f54f@xeon-e3>
Date:   Fri, 18 Aug 2017 08:55:19 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Phil Sutter <phil@....cc>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH v2 1/7] ipaddress: Make buffer for filter.flushb
 static

On Fri, 18 Aug 2017 13:57:03 +0200
Phil Sutter <phil@....cc> wrote:

> On Thu, Aug 17, 2017 at 07:09:25PM +0200, Phil Sutter wrote:
> > The buffer is accessed outside of the function defining it, so make it
> > static.
> > 
> > Signed-off-by: Phil Sutter <phil@....cc>  
> 
> Self-NACK: Access to flushb should be sane since all accessors are
> called from ipaddr_flush(). Looking at the covscan output again, it
> merely complained about filter.flusb still pointing to the local buffer
> when ipaddr_flush() returns.
> 
> Cheers, Phil

Ok, dropping this  sub-series