netdev - Re: [PATCH net v2] datagram: When peeking datagrams with offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-+GgSo1MXTT-7ADzs2ktKMQRhiH+0zMg+rwX0BA9+1SDQ@mail.gmail.com>
Date:   Fri, 18 Aug 2017 13:56:10 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Matthew Dawson <matthew@...systems.ca>
Cc:     Paolo Abeni <pabeni@...hat.com>,
        Network Development <netdev@...r.kernel.org>,
        "Macieira, Thiago" <thiago.macieira@...el.com>
Subject: Re: [PATCH net v2] datagram: When peeking datagrams with offset < 0
 don't skip empty skbs

>> > +   if (flags & MSG_PEEK && *off >= 0) {
>> > +           peek_at_off = true;
>> > +           _off = *off;
>> > +   }
>>
>> I think that unlikely() will fit the above condition
> Sounds good.

Doesn't the compiler implicitly mark branches as unlikely if they
do not have an else clause?