netdev - Re: [PATCH v3 net-next] ipv4: convert dst_metrics.refcnt from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2017 15:14:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH v3 net-next] ipv4: convert dst_metrics.refcnt from
 atomic_t to refcount_t

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 18 Aug 2017 12:08:07 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> v3: added the include <linux/refcount.h> to be safe (Cong Wang)
> v2: fix a missing change in net/ipv4/fib_semantics.c

Applied, thanks Eric.