netdev - Re: [PATCH net] ipv6: reset fn->rr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170818.160438.850095067230428660.davem@davemloft.net>
Date:   Fri, 18 Aug 2017 16:04:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net] ipv6: reset fn->rr_ptr when replacing route

From: Wei Wang <weiwan@...gle.com>
Date: Wed, 16 Aug 2017 11:18:09 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> syzcaller reported the following use-after-free issue in rt6_select():
 ...
> The root cause of it is that in fib6_add_rt2node(), when it replaces an
> existing route with the new one, it does not update fn->rr_ptr.
> This commit resets fn->rr_ptr to NULL when it points to a route which is
> replaced in fib6_add_rt2node().
> 
> Fixes: 27596472473a ("ipv6: fix ECMP route replacement")
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.