netdev - Re: [PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170818.160623.1816130769638429758.davem@davemloft.net>
Date:   Fri, 18 Aug 2017 16:06:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, fw@...len.de, dsa@...ulusnetworks.com,
        idaifish@...il.com, syzkaller@...glegroups.com, dvyukov@...gle.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net v2] net: check and errout if res->fi is NULL when
 RTM_F_FIB_MATCH is set

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Wed, 16 Aug 2017 12:38:52 -0700

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Syzkaller hit 'general protection fault in fib_dump_info' bug on
> commit 4.13-rc5..
> 
> Guilty file: net/ipv4/fib_semantics.c
 ...
> This patch adds a res->fi NULL check.
> 
> example run:
> $ip route get 0.0.0.0 iif virt1-0
> broadcast 0.0.0.0 dev lo
>     cache <local,brd> iif virt1-0
> 
> $ip route get 0.0.0.0 iif virt1-0 fibmatch
> RTNETLINK answers: No route to host
> 
> Reported-by: idaifish <idaifish@...il.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Fixes: b61798130f1b ("net: ipv4: RTM_GETROUTE: return matched fib result when requested")
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thank you.