netdev - Re: [PATCH net-next] bpf: Fix map-in-map checking in the verifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59964C1A.7050902@gmail.com>
Date:   Thu, 17 Aug 2017 19:08:26 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <ast@...com>, Martin KaFai Lau <kafai@...com>,
        netdev@...r.kernel.org
CC:     Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com
Subject: Re: [PATCH net-next] bpf: Fix map-in-map checking in the verifier

On 08/17/2017 06:17 PM, Alexei Starovoitov wrote:
> On 8/17/17 6:14 PM, Martin KaFai Lau wrote:
>> In check_map_func_compatibility(), a 'break' has been accidentally
>> removed for the BPF_MAP_TYPE_ARRAY_OF_MAPS and BPF_MAP_TYPE_HASH_OF_MAPS
>> cases.  This patch adds it back.
>>
>> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
>> Cc: John Fastabend <john.fastabend@...il.com>
>> Signed-off-by: Martin KaFai Lau <kafai@...com>
> 
> Nice catch!
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> 

Thanks a lot!

Acked-by: John Fastabend <john.fastabend@...il.com>